-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-switch) add new web component #102
Conversation
} | ||
} | ||
|
||
onkeydown(event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use the onsap____
? We need to discuss if it is really needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by it
I mean onsap__
psuedo events generation
static getMainClasses(state) { | ||
return { | ||
"ui5-switch": true, | ||
"ui5-switch--disabled": state.disabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classes look good to me, but we need to discuss if we are staying with that BEM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classes look good to me, but we need to discuss if we are staying with that BEM
For sure we should discuss it, I liked it as well.
} | ||
|
||
.ui5-switch-text--on { | ||
left: calc(~"-100% + 1.9125rem"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, should you escape the whole calc
expression like ~"calc(100% .. )"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, should you escape the whole
calc
expression like~"calc(100% .. )"
Yes, in the less files we should escape the calc, once we move the styles in css, we can remove the escaping.
No description provided.