feat(ui5-switch) add new web component #102
Conversation
| } | ||
| } | ||
|
|
||
| onkeydown(event) { |
There was a problem hiding this comment.
maybe use the onsap____? We need to discuss if it is really needed
There was a problem hiding this comment.
by it I mean onsap__ psuedo events generation
| static getMainClasses(state) { | ||
| return { | ||
| "ui5-switch": true, | ||
| "ui5-switch--disabled": state.disabled, |
There was a problem hiding this comment.
classes look good to me, but we need to discuss if we are staying with that BEM
There was a problem hiding this comment.
classes look good to me, but we need to discuss if we are staying with that BEM
For sure we should discuss it, I liked it as well.
| } | ||
|
|
||
| .ui5-switch-text--on { | ||
| left: calc(~"-100% + 1.9125rem"); |
There was a problem hiding this comment.
hmm, should you escape the whole calc expression like ~"calc(100% .. )"
There was a problem hiding this comment.
hmm, should you escape the whole
calcexpression like~"calc(100% .. )"
Yes, in the less files we should escape the calc, once we move the styles in css, we can remove the escaping.
No description provided.