fix(ui5-select): prevent selection from cycling #1066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We stopped the ui5-list from cycling the focus. The ui5-select internally uses a list to display its options, but cycles the selection and there is a mismatch between the selected option and the option on focus.
Now, both the focus and the selection matches and do not cycle (as the sap.m.Select in openui5)
Before
![ezgif com-video-to-gif](https://user-images.githubusercontent.com/15702139/70887796-73dd2280-1fe7-11ea-9c05-5a8f2d66c383.gif)
After
![ezgif com-video-to-gif](https://user-images.githubusercontent.com/15702139/70887712-45f7de00-1fe7-11ea-880f-e26461254432.gif)