refactor(ui5-textarea): rename property maxLength to maxlength #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The property maxLength has been renamed to maxlength. Also, the attribute name is changed from max-length to maxlength.
MapTo0
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
We should also adopt the samples once we get this released - https://github.com/SAP-samples/ui5-webcomponents-sample-react/search?q=ui5-textarea&unscoped_q=ui5-textarea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ui5-input has the same property and it is called
maxlength(lowercase) and as the native input element attribute is called the same way, we decided to rename ui5-textareamaxLength(camelcase) tomaxlength(lowercase)BREAKING CHANGE: The property
maxLengthhas been renamed tomaxlength.Also, the corresponding attribute name is changed from
max-lengthtomaxlength.