Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge metadata properly #1092

Merged
merged 1 commit into from
Dec 23, 2019
Merged

fix: Merge metadata properly #1092

merged 1 commit into from
Dec 23, 2019

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Dec 23, 2019

  • The metadata objects were not merged correctly due to calling Array.prototype.reverse several times in a row, while not considering it changes the original object, thus when merging slots, it was done in the opposite direction
  • The merge was not deep so you couldn't just override a setting for a property or slot for example
  • Additionally the variable klass was used only when necessary for clarity (when looping over prototypes), for the rest this is more intuitive

This changes uses the deep merge merge.js from the utils project.

closes: #454

@vladitasev vladitasev merged commit 6a29872 into master Dec 23, 2019
@vladitasev vladitasev deleted the deep-merge-metadata branch December 23, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in UI5Metadata when inheriting a web component
2 participants