Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(framework): Allow the registration of custom themes #1109

Merged
merged 1 commit into from
Jan 6, 2020
Merged

feature(framework): Allow the registration of custom themes #1109

merged 1 commit into from
Jan 6, 2020

Conversation

vladitasev
Copy link
Contributor

Creating a custom theme is largely possible today with a couple of slight adjustments:

  • Change the theme registry to allow for custom themes (instead of hard-coded list with ours)
  • Document (both in jsdoc and .md) the registerThemeProperties method
  • Add a test

@vladitasev vladitasev mentioned this pull request Jan 3, 2020
Closed
ilhan007
ilhan007 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it with feat(framework), not feature(framework).

@vladitasev vladitasev merged commit 6a69521 into master Jan 6, 2020
@vladitasev vladitasev deleted the custom-theming branch January 6, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

@pskelin pskelin Awaiting requested review from pskelin

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladitasev @ilhan007