feat(framework): OpenUI5 integration #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
force-pushed
the
ui5-integration
branch
from
3baf45f
to
9e377b6
Compare
pskelin
previously approved these changes
Feb 11, 2020
packages/base/src/UI5Element.js
Outdated
| * @protected | ||
| * @returns {Promise<void>} | ||
| */ | ||
| static async onDefine() { |
There was a problem hiding this comment.
hooks don't need to be defined on the base class. Also at the call site there is already a check if the hook is present, so better remove this one.
ilhan007
previously approved these changes
Feb 11, 2020
fifoosid
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenUI5Supportis a newbasefeatureboot.jsandInitialConfiguration.jsto sync with OpenUI5 on configuration level