Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-tabcontainer): add tabLayout property #1214

Merged
merged 8 commits into from
Feb 18, 2020
Merged

feat(ui5-tabcontainer): add tabLayout property #1214

merged 8 commits into from
Feb 18, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Feb 12, 2020 •
edited
Loading

Fixes: #1195

Screenshot 2020-02-12 at 4 31 27 PM

fifoosid
fifoosid previously requested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a whole I like the solution, but I was wondering whether it is a better idea to set the tab-layout property on ui5-tabcontainer, because an app would like all the tabs in a single tab container to have the same layout.

packages/main/src/Tab.js Outdated Show resolved Hide resolved
packages/main/src/themes/TabContainer.css Show resolved Hide resolved
packages/main/src/types/TabLayout.js Outdated Show resolved Hide resolved
packages/main/src/types/TabLayout.js Outdated Show resolved Hide resolved
packages/main/src/types/TabLayout.js Outdated Show resolved Hide resolved
vladitasev
vladitasev previously requested changes Feb 13, 2020
View reviewed changes
packages/main/src/Tab.js Outdated Show resolved Hide resolved
@ilhan007
Copy link
Member Author

As a whole I like the solution, but I was wondering whether it is a better idea to set the tab-layout property on ui5-tabcontainer, because an app would like all the tabs in a single tab container to have the same layout.

I was thinking the same, actually I was about to bring this for a discussion, but now I think it will be easier for user to set it once, moreover it's not by Fiori to have mixed layouts

@ilhan007 ilhan007 changed the title feat(ui5-tab): add design property feat(ui5-tabcontainer): add tabLayout property Feb 17, 2020
@ilhan007 ilhan007 dismissed stale reviews from fifoosid and vladitasev February 17, 2020 07:15

outdated

@ilhan007 ilhan007 merged commit e79dcc8 into master Feb 18, 2020
@ilhan007 ilhan007 deleted the refactor-tab-container branch February 18, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab container: support tab label with count
3 participants
@ilhan007 @vladitasev @fifoosid