Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-static-area-item): implement lazy loading #1272

Merged
merged 8 commits into from
Mar 18, 2020
Merged

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Mar 9, 2020

No description provided.

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great - I think this is the way to go.
The only problem I've found is that datepicker/select/etc.. blink when you click their icon. Try comparing f.e. datepicker on live with datepicker now and you'll notice the blue background of the icon

@vladitasev
Copy link
Contributor

@pskelin Currently there is a noticeable delay (picker icon flickers) due to the fact that some of the work happens later now, because the static area items are created on the fly. There are 2 ways to address:

  • change the logic of some components to update the icon first
  • start using microtask instead of animation frame for rendering. Do you see issues with the second?

@vladitasev vladitasev requested a review from pskelin March 13, 2020 10:40
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TabContainer is broken - the popover resizes immediatly after opening and takes up the whole screen

@fifoosid fifoosid merged commit 1f76a71 into master Mar 18, 2020
@fifoosid fifoosid deleted the static-area-lazy branch March 18, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants