Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-dialog): improve accessibility #1288

Merged
merged 3 commits into from
Mar 12, 2020
Merged

feat(ui5-dialog): improve accessibility #1288

merged 3 commits into from
Mar 12, 2020

Conversation

fifoosid
Copy link
Contributor

Fixes #1280

@elenastoyanovaa elenastoyanovaa self-assigned this Mar 12, 2020
ilhan007
ilhan007 requested changes Mar 12, 2020
View reviewed changes
packages/main/src/Popup.hbs Outdated Show resolved Hide resolved
@fifoosid fifoosid merged commit ef2886b into master Mar 12, 2020
@fifoosid fifoosid deleted the dialog-header-acc branch March 12, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees

@elenastoyanovaa elenastoyanovaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-dialog: Header text should be read out
3 participants
@fifoosid @ilhan007 @elenastoyanovaa