Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-input): fix exceptions thrown when KH used #1301

Merged
merged 2 commits into from
Mar 16, 2020
Merged

fix(ui5-input): fix exceptions thrown when KH used #1301

merged 2 commits into from
Mar 16, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Mar 15, 2020 •
edited
Loading

Fix exceptions thrown when keyboard handling is used. When the input has suggestions, moving up/down throws exception in few cases: always when the suggestions popup is closed and always when it is opened and tries to bring an item into view

  • fix: the ScrollContainer (that moves the item into view) used to throw exceptions
  • fix: handle UP/DOWN when the suggestions are opened, otherwise we prevent the default behaviour - bringing the cursor to the start/end of the input text
  • fix: the icons of the items are not displayed

@ilhan007 ilhan007 merged commit 85f01d7 into master Mar 16, 2020
@ilhan007 ilhan007 deleted the fix-input branch March 16, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilhan007 @vladitasev