Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ListItemType): add Detail type #1323

Merged
merged 2 commits into from
Mar 20, 2020
Merged

feat(ListItemType): add Detail type #1323

merged 2 commits into from
Mar 20, 2020

Conversation

dimovpetar
Copy link
Contributor

@dimovpetar dimovpetar commented Mar 20, 2020 •
edited
Loading

Added new enumeration value in ListItemType.
When ListItemType.Detail is used, list items show edit icon. When this icon is pressed, the coresponding list item fires "detailClick" event.

ilhan007
ilhan007 requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add one sample for the playground
  • import the edit icon in ListItem.js to ensure it would be displayed (in the test pages we import all the icons and that's why all they are available, but in applications the user can import icons one by one)

@dimovpetar
Copy link
Contributor Author

  • add one sample for the playground
  • import the edit icon in ListItem.js to ensure it would be displayed (in the test pages we import all the icons and that's why all they are available, but in applications the user can import icons one by one)

Import is done

@vladitasev vladitasev merged commit ac8f8ce into SAP:master Mar 20, 2020
@dimovpetar dimovpetar deleted the listtype branch April 3, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimovpetar @ilhan007 @vladitasev