feat(ui5-duration-picker): initial implementation #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
changed the title
vladitasev
requested changes
Apr 3, 2020
There was a problem hiding this comment.
UPDATE: After a discussion, we decided it's better this way.
I think it should be:
ui5-durationpicker
to be consistent with:
ui5-datepicker
ui5-timepicker
Other than that, I tested everything, including IE, and it seems to work. No problems I could see with the code either
vladitasev
approved these changes
Apr 3, 2020
|
Please proceed to merge with this name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.