feat(ui5-carousel): Allow different number of items per page based on component width #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
changed the title
ilhan007
approved these changes
Apr 6, 2020
vladitasev
changed the title
fifoosid
suggested changes
Apr 6, 2020
There was a problem hiding this comment.
Looks good to me, but I noticed two things:
- If you have
<ui5-carousel items-per-page-m="3" items-per-page-l="4" selected-index="6">with 7 items for example, in both M and L sizes the selected index would be 6 altough only 2/3 pages are available.
- The sample page should be updated due to the braking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui5-carouselis now size-aware:ResizeHandleritemsPerPagereplaced byitemsPerPageS,itemsPerPageManditemsPerPageL. They all have default value of1so a plainui5-carouselwithout any properties set will behave as before. The user can now increase the number of items for different screen sizes separately. Since the default value foritemsPerPageSis1, no special logic is needed for phone any more.cyclingrenamed tocyclicas this is the correct adjectiveBREAKING CHANGE:
The
cyclingproperty was renamed tocyclic.The
itemsPerPageproperty was replaced by 3 new properties:itemsPerPageS,itemsPerPageManditemsPerPageL. To achieve exactly the same result as before, setitemsPerPageManditemsPerPageLto whatever the value ofitemsPerPagewas, but it's recommended to set them independently for best user experience.