fix(ui5-shellbar): check for profile correctly #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested review from
MapTo0,
MarcusNotheis,
pskelin,
ilhan007 and
fifoosid
ilhan007
approved these changes
Apr 7, 2020
fifoosid
approved these changes
Apr 7, 2020
MarcusNotheis
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
profilewas turned into a slot, the check whether there is a profile element provided, remainedthis.profilewhich is always truthy for a slot (since it's an array).Additionally, the line
show: this.profilewhich is supposed to be a Boolean, became an array, holding a reference to theui5-avatarinstance that the user passed, making it fail when transformed intoJSONfor the purpose of object comparison.The fix is to check whether the avatar array is not empty.
closes: #1427