feat(ui5-carousel): add navigate event #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
vladitasev
reviewed
Apr 9, 2020
There was a problem hiding this comment.
There is also the possibility of pages changing due to the user resizing the carousel or the developer removing items from the carousel.
Overall I think pages are unreliable and it would be better to start working with items. I have a change for this, but incomplete. Let's wait until I've merged it and then we can implement the events too
ilhan007
changed the title
vladitasev
reviewed
Apr 23, 2020
| @@ -24,13 +24,15 @@ | |||
| {{#if arrows.content}} | |||
| <div class="ui5-carousel-navigation-arrows"> | |||
| <ui5-button | |||
| arrow-back | |||
There was a problem hiding this comment.
it is used in the test to retrieve the backward arrow in more explicit way, but I guess ui5-carousel-navigation-arrows[0] will work as well, I can change it if you want
vladitasev
previously approved these changes
Apr 23, 2020
vladitasev
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event is fired whenever the selectedIndex changes due to user interaction - when the user clicks on the navigation arrows or while resizing, based on the "items-per-page-s/m/l" properties.
Fixes: #1449