(ui5-list): implement accessibility spec #1461
Conversation
packages/main/src/ListItem.hbs
Outdated
| @@ -74,6 +76,7 @@ | |||
| design="Transparent" | |||
| icon="decline" | |||
| @click="{{onDelete}}" | |||
| title="Delete" | |||
| > | ||
| <span class="ui5-hidden-text">Group Header</span> |
| @@ -1,9 +1,12 @@ | |||
| <li | |||
| tabindex="{{_tabIndex}}" | |||
| tabindex="0" | |||
There was a problem hiding this comment.
Not sure, but at least in ui5 when the user presses TAB from a group list item, the focus leaves the list. Hardcoded "0" means that if the list has more than 1 group list item, TAB will move the focus from the first to the second and this might contradict the spec. In addition the ItemNavigation works with these _tabIndex and this change might interfere the tab order.
The spec should be checked and if an example with mixed types of list items works with Arrows UP/DOWN and TAB| SHIFT + TAB according to the spec I am fine with the change.
There was a problem hiding this comment.
The spec says that it should always be 0. @elenastoyanovaa what do you think?
There was a problem hiding this comment.
it is just a copied value, leave it like it is
There was a problem hiding this comment.
The question is if the tabindex of the group item should be always 0, which means the tab will move from group item to group item, instead of leaving the List.
At least in openui5 it is not like that, the focus leaves the List if the users tab from a group item (https://openui5nightly.hana.ondemand.com/entity/sap.m.List/sample/sap.m.sample.ListGrouping), so I wonder what is the correct behaviour?
There was a problem hiding this comment.
After we discussed it, we decided that it should not be hardcoded.
| class="ui5-ghli-root {{classes.main}}" | ||
| @focusin="{{_onfocusin}}" | ||
| @focusout="{{_onfocusout}}" | ||
| role="listbox" |
There was a problem hiding this comment.
as discussed, this should be option
| @@ -1,9 +1,12 @@ | |||
| <li | |||
| tabindex="{{_tabIndex}}" | |||
| tabindex="0" | |||
There was a problem hiding this comment.
The question is if the tabindex of the group item should be always 0, which means the tab will move from group item to group item, instead of leaving the List.
At least in openui5 it is not like that, the focus leaves the List if the users tab from a group item (https://openui5nightly.hana.ondemand.com/entity/sap.m.List/sample/sap.m.sample.ListGrouping), so I wonder what is the correct behaviour?
Fixes #1283
Related to #1426