feat(ui5-segmentedbutton): implement accessibility spec

[tsanislavgatev]

fixes: #1286

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

• Reviewed the Contributing Guidelines
  • Especially the How to Contribute section
• Correct commit message style

[vladitasev]

1. The class seems to do nothing? Unless there should be some css for it, please delete it

2. aria-checked does not change upon space. It changes whenever the segmented button itself is rerendered later, for whatever reason. If you want the segmented button to be invalidated whenever the children are invalidated (and you do in this case), you should use listenFor in the slot metadata.

"default": { propertyName: "buttons", type: HTMLElement, individualSlots: true, listenFor: { include: ["pressed"] } },
Once you do this, whenever pressed changes for a toggle button, the template for segmented button will be re-evaluated and the aria-checked binding will be updated as well.

[tsanislavgatev]

Done. The classes are now currently used for selecting the wrapper divs and applying the style.

[vladitasev]

Also, now that you added the divs, they add paddings/margins and overall alter the space, taken up by the segmented button.

See the root div on master:

It should remain with the same properties after your change

[ilhan007]

if it closes this issue, reference it:
#1286

[vladitasev]

Is this everything or work in progress? Shouldn't there be more information about the current options, selected option, etc... pretty much like a Select comonent?

[vladitasev]

Is this really the right text? Isn't "Segmented button" a term only we know, and not meant for the end user?

[tsanislavgatev]

That's the specification given me by @elenastoyanovaa .
Eli, I think you can give more information?

[elenastoyanovaa]

Yes, this is the right text. Since the component/control is specific we are adding an aria-roledescription according to Aria 1.1. This is already discussed and will also be implemented in openui5.

[elenastoyanovaa]

Approved from ACC side