Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-responsive-popover): implement default close button #1501

Merged
merged 4 commits into from
Apr 23, 2020
Merged

fix(ui5-responsive-popover): implement default close button #1501

merged 4 commits into from
Apr 23, 2020

Conversation

fifoosid
Copy link
Contributor

Fixes #1494

ilhan007
ilhan007 requested changes Apr 21, 2020
View reviewed changes
packages/main/src/ResponsivePopover.hbs Outdated Show resolved Hide resolved
ilhan007
ilhan007 requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the title is too long, the close button is moved out of the viewport

@fifoosid fifoosid merged commit c6868af into master Apr 23, 2020
@fifoosid fifoosid deleted the resp-popover-button branch April 23, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No close button showing in the header of ResponsivePopover on phone
2 participants
@fifoosid @ilhan007