feat(ui5-tabcontainer): content can be displayed above the tab strip #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
previously approved these changes
Apr 23, 2020
There was a problem hiding this comment.
It looks good to me. I just have one comment regarding the property name. I feel like the tabs position should be leading in the naming the property. Maybe sth similar to the Carousel arrowsPlacement="Content|Navigation" can be appropriate here as well, like: tabsPlacement="Top|Bottom, Top by default".
If it should be a boolean: bottom-navigation navigation-bottom, tabs-to-bottom. But, it is just an opinion, I will approve it as it is.
|
I'll change the name, what you said makes sense |
ilhan007
previously approved these changes
Apr 23, 2020
ilhan007
reviewed
Apr 23, 2020
packages/main/src/TabContainer.js
Outdated
| * bottom of the page and you want the tab strip to act as a menu. | ||
| * | ||
| * @type {boolean} | ||
| * @defaultvalue false |
There was a problem hiding this comment.
type TabContainerTabsPlacement
defaultvalue Top
since 1.0.0-rc.7
ilhan007
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
tabsPlacementproperty (Topby default) lets the user position the content area above the tab strip by settingtabsPlacementtoBottom. By doing so, the overflow menu arrow also changes direction to point upwards, rather than downwards.