Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): rendering is no longer delayed #1552

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Apr 27, 2020

  • When there are not-imported UI5 Elements on the page, each rendering cycle is delayed by 5 seconds, making the whole page unresponsive. This is an extract from this pull request: chore(framework): Improve RenderScheduler.js #1308 :
  • All elements are registered centrally (so not only UI5Element.js can access this information)
  • RenderScheduler.js no longer guesses which elements are UI5 Elements, but reads this from the registry, and no longer waits for 5 seconds. If an element is imported, its awaited until it's defined.
  • Additionally the whenShadowDOMReady function was renamed as its name was misleading.

As a result of this change, it's now possible to have UI5 Elements that don't start with ui5-.

closes: #1537

@vladitasev vladitasev merged commit c26e8aa into master Apr 27, 2020
@vladitasev vladitasev deleted the fix-rendering-delay branch April 27, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-select: cannot select an item with space/enter
2 participants