Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-icon): introduce interactive property #1592

Merged
merged 3 commits into from
May 13, 2020
Merged

feat(ui5-icon): introduce interactive property #1592

merged 3 commits into from
May 13, 2020

Conversation

fifoosid
Copy link
Contributor

Fixes #1532

ilhan007
ilhan007 previously approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can clarify that the click is fired when interactive is enabled. Besides that, I approve the change.

@fifoosid fifoosid closed this May 12, 2020
@fifoosid fifoosid reopened this May 12, 2020
vladitasev
vladitasev requested changes May 12, 2020
View reviewed changes
packages/main/src/Icon.js Outdated Show resolved Hide resolved
@fifoosid fifoosid merged commit b898cd3 into master May 13, 2020
@fifoosid fifoosid deleted the interactive-icon branch May 13, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@ilhan007 ilhan007 ilhan007 left review comments

Assignees
No one assigned
Labels
for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-icon should have interactive mode
3 participants
@fifoosid @ilhan007 @vladitasev