Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-icon): Icon now has a correct role #1652

Merged
merged 2 commits into from
May 20, 2020
Merged

fix(ui5-icon): Icon now has a correct role #1652

merged 2 commits into from
May 20, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented May 20, 2020

Until now ui5-icon had a fixed role attribute - it was always img.

Now, according to the accessibleName and interactive properties, it may be button, img or presentation.

The default role of all icons is now presentation. The only way to change this is to set either interactive to true (so you get role=button) or to set accessibleName, in which case you get img.

In addition: a missing closing </div> was added.

closes: #1581

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving the change from code point of you, up to you if you want to wait for the ACC expert input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svg do not have proper accessibility attribute
3 participants