fix(ui5-icon): Icon now has a correct role #1652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now
ui5-icon
had a fixedrole
attribute - it was alwaysimg
.Now, according to the
accessibleName
andinteractive
properties, it may bebutton
,img
orpresentation
.The default
role
of all icons is nowpresentation
. The only way to change this is to set eitherinteractive
totrue
(so you getrole=button
) or to setaccessibleName
, in which case you getimg
.In addition: a missing closing
</div>
was added.closes: #1581