Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-duration-picker: it's not possible to extend the duration beyond 23:59:59 #1660

Closed
Lukas742 opened this issue May 20, 2020 · 0 comments · Fixed by #1666
Closed

ui5-duration-picker: it's not possible to extend the duration beyond 23:59:59 #1660

Lukas742 opened this issue May 20, 2020 · 0 comments · Fixed by #1666
Assignees
@fifoosid
Labels
bug This issue is a bug in the code

Comments

@Lukas742
Copy link
Collaborator

Describe the bug
It's not possible to add a maxValue greater than 23:59:59.

To reproduce
Steps to reproduce the behavior:

  1. Add value="99:30:00" to the ui5-duration-picker
  2. See that only the minutes are applied to the input field.

Isolated example
https://codesandbox.io/s/ui5-webcomponents-klv4r?file=/index.html

Expected behavior
As this is not a timepicker I would expect to be able to select more than 24h.
@fifoosid fifoosid self-assigned this May 21, 2020
@fifoosid fifoosid added the bug This issue is a bug in the code label May 21, 2020
@fifoosid fifoosid mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
bug This issue is a bug in the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-duration-picker): maxValue can be greater than 23:59:59 SAP/ui5-webcomponents
2 participants
@Lukas742 @fifoosid