feat(ui5-tools): libraries can now control chromedriver version #1684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently third-party libraries that use UI5 Web Components tools cannot control
chromedriver
version, which may be problematic whenever Google Chrome isn't automatically updated on their system.To solve this, we're moving
chromedriver
to a peer dependency rather than a dev dependency to@ui5/webcomponents-tools
. All packages, internal or external, must now specify a suitable for themchromedriver
version.BREAKING CHANGE: If you are a UI5 Web Components third-party library author, you need to add a dev dependency to
chromedriver
in your project.For example, if you had:
you should change this to:
Feel free to choose a version that suits your specific use case best, or
latest
if in doubt.closes: #1682