Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-tools): libraries can now control chromedriver version #1684

Merged
merged 4 commits into from
May 27, 2020

Conversation

vladitasev
Copy link
Contributor

Currently third-party libraries that use UI5 Web Components tools cannot control chromedriver version, which may be problematic whenever Google Chrome isn't automatically updated on their system.

To solve this, we're moving chromedriver to a peer dependency rather than a dev dependency to @ui5/webcomponents-tools. All packages, internal or external, must now specify a suitable for them chromedriver version.

BREAKING CHANGE: If you are a UI5 Web Components third-party library author, you need to add a dev dependency to chromedriver in your project.
For example, if you had:

  "devDependencies": {
    "@ui5/webcomponents-tools": "1.0.0-rc.7"
  }

you should change this to:

  "devDependencies": {
    "@ui5/webcomponents-tools": "1.0.0-rc.7",
    "chromedriver": "latest"
  }

Feel free to choose a version that suits your specific use case best, or latest if in doubt.

closes: #1682

@vladitasev
Copy link
Contributor Author

Note: unfortunately we cannot set a predefined version in .travis.yml as it only allows for stable and beta. This is intended so it's up to us to fix the build on demand whenever a new Google Chrome version arrives.

ilhan007
ilhan007 previously approved these changes May 27, 2020
pskelin
pskelin previously approved these changes May 27, 2020
@vladitasev vladitasev dismissed stale reviews from pskelin and ilhan007 via c376ef7 May 27, 2020 06:37
ilhan007
ilhan007 previously approved these changes May 27, 2020
@vladitasev vladitasev merged commit 2da6a34 into master May 27, 2020
@vladitasev vladitasev deleted the externalize-chromedriver-version branch May 27, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools: update chromedriver version manually
3 participants