feat(ui5-rating-indicator): initial implementation #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested changes
Jun 5, 2020
ilhan007
requested changes
Jun 5, 2020
| } | ||
|
|
||
| const down = isDown(event) || isLeft(event); | ||
| const up = isRight(event) || isUp(event) || isSpace(event) || isEnter(event); |
There was a problem hiding this comment.
With Space and Enter, after the values reaches the maxValue (all starts are active) it starts over, it is cycling behaviour basically. This is how in openui5 works at least.
With Up/Left and Down/Right it is like currently works.
ilhan007
requested changes
Jun 5, 2020
ilhan007
requested changes
Jun 5, 2020
ilhan007
requested changes
Jun 5, 2020
ilhan007
requested changes
Jun 5, 2020
ilhan007
requested changes
Jun 5, 2020
| } | ||
|
|
||
| :host([_focused]) { | ||
| outline: 1px dotted var(--sapContent_FocusColor); |
There was a problem hiding this comment.
The focus should be just around the stars:
currently is:
The problem is not with the css for the outline, but the stars itself or the wrapper.
ilhan007
requested changes
Jun 5, 2020
ilhan007
requested changes
Jun 5, 2020
ilhan007
requested changes
Jun 5, 2020
ilhan007
previously requested changes
Jun 5, 2020
vladitasev
reviewed
Jun 5, 2020
There was a problem hiding this comment.
@ilhan007 has already noted most of the things I noticed as well, so I'll just go over the more important ones to me:
- Disabled state: the desired opacity is 0.4
- Focus should be around the stars
- In OpenUI5 the size is dynamic, you can give it in rems. Explore this option for us - both here and maybe busy indicator
The change adds RTL support, basically mirrors the borders of the first and the last button.
vladitasev
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1717