Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-timepicker): fix firing "change" event for the same value #1764

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jun 10, 2020

Previously the TImePicker used to fire "change" event unconditionally upon "Submit" press.
Now, the value is checked and if it is changed, the event will be fired.

Additionally, the following has been removed from the constructor as these are existing boolean properties that by default are false

this.readonly = false;
this.disabled = false;

@ilhan007 ilhan007 changed the title fix(ui5-timepicker): stop firing change event for same time fix(ui5-timepicker): stop firing change event for same value Jun 10, 2020
@ilhan007 ilhan007 changed the title fix(ui5-timepicker): stop firing change event for same value fix(ui5-timepicker): fix firing "change" event for the same value Jun 10, 2020
@ilhan007 ilhan007 merged commit 3a0c7d5 into master Jun 10, 2020
@ilhan007 ilhan007 deleted the fix-tp-change branch June 10, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants