Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-avatar): Correct colors are applied for acc themes #1786

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

vladitasev
Copy link
Contributor

For normal themes, ui5-avatar fulfilled the Fiori design, but for accessibility themes, there are different requirements:

  • there must be a border for icon and initial type avatars
  • background and text color must be purely black/white (no accent colors).

This change extracts all necessary variables to fulfill this.

Expected design:
image
image

closes: #1780

@vladitasev vladitasev merged commit 42f1766 into master Jun 12, 2020
@vladitasev vladitasev deleted the fix-avatar-acc-themes branch June 12, 2020 13:41
@ilhan007 ilhan007 added this to 1.0.0-rc.8 (released) in UI5 Web Components - Roadmap Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar: Text color is not right
2 participants