fix: fix source maps #181
Merged
fix: fix source maps #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template files with DOS line endings are breaking the source map. Convert DOS line endings to Unix line endings when generating renderers. This way, .hbs files with DOS line endings (no eslint) will not break the source maps as the generated renderer will have the correct line ending
adrian-bobev
approved these changes
Mar 14, 2019
we could add them for sure, but templates from other repositories that do not have the correct line ending should still be processed correctly by the conversion which is the more important aspect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template files with DOS line endings are breaking the source map.
Convert DOS line endings to Unix line endings when generating renderers.
This way, .hbs files with DOS line endings (no eslint) will not break the source
maps as the generated renderer will have the correct line ending.
The change is also correcting the line endings of existing .hbs templates.