Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-avatar): image URL may now contain special characters #1828

Merged
merged 2 commits into from
Jun 18, 2020
Merged

fix(ui5-avatar): image URL may now contain special characters #1828

merged 2 commits into from
Jun 18, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Jun 18, 2020 •
edited
Loading

When dealing with background-image: url(...) the best practice is to:

  • enclose the expression in ( and ) with "", f.e. url("myImage.png")
  • encode the whole URI with encodeURIComponent.

An additional image with special characters was added to the test page.

closes: #1827

@vladitasev vladitasev merged commit 3acab5a into master Jun 18, 2020
@vladitasev vladitasev deleted the fix-avatar-image-url branch June 18, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatar cannot render image from OData path
2 participants
@vladitasev @ilhan007