Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-progress-indicator): init implementation #1887

Merged
merged 12 commits into from
Jul 5, 2020
Merged

feat(ui5-progress-indicator): init implementation #1887

merged 12 commits into from
Jul 5, 2020

Conversation

nnaydenow
Copy link
Contributor

Fixes: #1392

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add demokit sample.

Add the component here: packages/playground/_site/build-scripts/samples-prepare.js to get the "new" label in playground.

packages/main/src/ProgressIndicator.hbs Show resolved Hide resolved
packages/main/src/ProgressIndicator.js Outdated Show resolved Hide resolved
packages/main/src/themes/ProgressIndicator.css Outdated Show resolved Hide resolved
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some several icons displayed in HCB when value state is set.

@ilhan007 ilhan007 closed this Jul 1, 2020
@ilhan007 ilhan007 reopened this Jul 1, 2020
@ilhan007 ilhan007 closed this Jul 1, 2020
@ilhan007 ilhan007 reopened this Jul 1, 2020
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the test

  • create method to get the validated value

const getValidatedValue = (pi) => {
return browser.execute((pi) => {
return pi.validatedValue;
}, pi);
};

  • use in the asserts

validButton.click();
assert.strictEqual(getValidatedValue(progressIndicator), 50, “The value is validated correctly.“);

@ilhan007 ilhan007 dismissed vladitasev’s stale review July 5, 2020 09:02

sample added, new label added

@ilhan007 ilhan007 merged commit e8009c9 into SAP:master Jul 5, 2020
@ilhan007 ilhan007 added this to 1.0.0-rc.8 (released) in UI5 Web Components - Roadmap Aug 7, 2020
@nnaydenow nnaydenow deleted the progressindicator branch August 10, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressIndicator component
5 participants