fix(framework): managedSlots: true always has effect #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
managedSlots: trueis set, the expectation is that you'll have properties for all children, no matter if you have a template or not.Until now, only components that render in the Shadow DOM (have a template) had their children processed and observed. However, it is possible to have abstract items that don't render in the Shadow DOM, but still need to have properties for their children. This becomes possible by moving the code related to managed slots out of the condition that checks for Shadow DOM usage.
Additionally, the
awaitbeforerenderImmediatelywas removed since it's no longer an async function.