fix(ui5-input): Suggestions can now be arbitrary list items #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
_getItemsfunction now reads all children of the list, regardless of tag name, so that for exampleui5-li-customwill also work.updateValueOnPreviewhook now gets not just a string, but the whole item as a parameter. This gives developers more freedom in determining what exactly is considered as the "preview value" of the item. This is handy for example ifui5-li-customis used and the value is just part of that.closes: #1967
BREAKING CHANGE: the format of the
updateValueOnPreviewhook has changed. The parameter is no longer a string (itemValue), but the wholeitemobject now. It is this hook's responsibility to determine whether/how to preview group items and inactive items too.