Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-segmentedbutton): buttons no longer shrink on click #2028

Merged
merged 1 commit into from
Jul 29, 2020
Merged

fix(ui5-segmentedbutton): buttons no longer shrink on click #2028

merged 1 commit into from
Jul 29, 2020

Conversation

vladitasev
Copy link
Contributor

When the component was rerendered, all button widths were reset to "". Therefore on click the segmented button used to collapse.

Now the full processing is done. _handleResize is renamed to _doLayout and called both onAfterRendering and upon resize.

closes: #1986

@vladitasev vladitasev merged commit 7951adc into master Jul 29, 2020
@vladitasev vladitasev deleted the seg-button-fix branch July 29, 2020 11:54
@ilhan007 ilhan007 added this to 1.0.0-rc.8 in UI5 Web Components - Roadmap Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SegmentedButton: the width of the component changes when clicking on any button
2 participants
@vladitasev @ilhan007