Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): process HBS files in nested directories #2067

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Aug 5, 2020

Now the the tools will process HBS files within nested directories and produce the output "lit" files into the "dist",
maintaining the file structures.

FIXES #2065

src/
----> myComponent
       ----> MyComponent.hbs (nested lvl 1)

                  ----> myComponentBadge
                           ----> MyComponentBadge.hbs (nested lvl 2)


dist/generated/templates/
 ----> myComponent
           ----> MyComponent.hbs (nested lvl 1)

                     ----> myComponentBadge
                              ----> MyComponentBadge.hbs (nested lvl 2)

Now the the tools will process HBS files within nested directories
@ilhan007 ilhan007 changed the title feat(tools): Process HBS files in nested dir feat(tools): Process HBS files in nested directories Aug 5, 2020
@ilhan007 ilhan007 added the SAP SF label Aug 5, 2020
@ilhan007 ilhan007 changed the title feat(tools): Process HBS files in nested directories feat(tools): process HBS files in nested directories Aug 5, 2020
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be safer to follow the same structure in the src/ and dist/generated/templates/ directories, because if you have dir1/MyComponent.js and dir2/MyComponent.js they will overwrite each other.

Another thing that comes to mind is: if people create subdirectories like common/ and store .hbs files such as headers, footers or other reusable parts, they would expect to find them in the same output directory.

What do you think? I don't strongly object against merging it like this, if there are specific reasons.

Now the the tools will process HBS files within nested directories
@ilhan007 ilhan007 added this to In progress in UI5 Web Components - Roadmap Aug 7, 2020
@ilhan007 ilhan007 removed this from In progress in UI5 Web Components - Roadmap Aug 7, 2020
@ilhan007 ilhan007 merged commit 13f1d2a into master Aug 10, 2020
@ilhan007 ilhan007 deleted the feat-tools-hbs2lit branch August 10, 2020 11:00
ilhan007 added a commit that referenced this pull request Aug 10, 2020
Now the the tools will process HBS files within nested directories and produce the output "lit" files into the "dist",
maintaining the file structures.

FIXES #2065
@ilhan007 ilhan007 added this to 0.21.11 (released Aug 10, 2020) in UI5 Web Components - Roadmap Aug 10, 2020
@ilhan007 ilhan007 moved this from 0.21.11 (released Aug 10, 2020) to 1.0.0-rc.9 (planned for Oct, 2020) in UI5 Web Components - Roadmap Aug 10, 2020
@ilhan007 ilhan007 moved this from 1.0.0-rc.9 (planned for Oct, 2020) to 0.21.11 (released Aug 10, 2020) in UI5 Web Components - Roadmap Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] webcomponents-tools support to compile the template .hbs files in sub-directories
2 participants