Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-popover): fix arrow horizontal position #2129

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Conversation

ilhan007
Copy link
Member

Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111

Perviously
Screenshot 2020-08-20 at 9 50 45 AM

Now the arrow position is correct
Screenshot 2020-08-20 at 9 41 21 AM
Screenshot 2020-08-20 at 9 41 31 AM

@ilhan007 ilhan007 merged commit 7a1c3eb into master Aug 21, 2020
@ilhan007 ilhan007 deleted the fix-popover-arrow-pos branch August 21, 2020 07:36
ilhan007 added a commit that referenced this pull request Aug 21, 2020
Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111
@ilhan007 ilhan007 added this to 0.23.1 (released Aug 24, 2020) in UI5 Web Components - Roadmap Aug 24, 2020
ilhan007 added a commit that referenced this pull request Oct 17, 2020
Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111
ilhan007 added a commit that referenced this pull request Nov 11, 2020
Fix Popover's arrow horizontal position, when horizontalPlacement is either "Left", or "Right".

FIXES #2111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-popover: [BUG] ui5-popover displays error when Left is set to horizontalAlign attribute
2 participants