Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-multi-input): fire value-help-trigger with F4, ALT/OPTION + ARROW_UP/DOWN #2145

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Aug 25, 2020

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger

…p/Down

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING_CHANGE value-help-icon-press is renamed to value-help-trigger
@ilhan007 ilhan007 requested a review from MapTo0 August 25, 2020 19:25
@ilhan007 ilhan007 changed the title feat(ui5-multi-inpuit): fire value-help-trigger with F4, ALT/OPTION + ARROW_UP/DOWN feat(ui5-multi-input): fire value-help-trigger with F4, ALT/OPTION + ARROW_UP/DOWN Aug 25, 2020
@ilhan007 ilhan007 closed this Aug 26, 2020
@ilhan007 ilhan007 reopened this Aug 26, 2020
@ilhan007 ilhan007 merged commit 8c473c3 into master Aug 26, 2020
@ilhan007 ilhan007 deleted the feat-multi-input-kh branch August 26, 2020 11:13
ilhan007 added a commit that referenced this pull request Sep 15, 2020
…ARROW_UP/DOWN (#2145)

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger
ilhan007 added a commit that referenced this pull request Oct 17, 2020
…ARROW_UP/DOWN (#2145)

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger
ilhan007 added a commit that referenced this pull request Nov 11, 2020
…ARROW_UP/DOWN (#2145)

Fire the value-help-trigger when F4 or ALT/OPTION + ARROW_UP/ARROW_DOWN keyboard keys are used.

FIXES #2143

BREAKING CHANGE value-help-icon-press is renamed to value-help-trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-multi-input: [a11y] cannot trigger value-help-icon-press event via keyboard
2 participants