Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-token): provide closeIcon slot #2193

Merged
merged 2 commits into from
Sep 14, 2020
Merged

feat(ui5-token): provide closeIcon slot #2193

merged 2 commits into from
Sep 14, 2020

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Sep 8, 2020

Fixes #2187

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I select the icon it looks strange:
image

while selecting the normal icon looks good:

image

@ilhan007 ilhan007 modified the milestone: 0.23.2 Sep 14, 2020
@fifoosid fifoosid merged commit d19fa5f into master Sep 14, 2020
@fifoosid fifoosid deleted the token-custom-icon branch September 14, 2020 07:27
Todor-ads pushed a commit to Todor-ads/ui5-webcomponents that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants