feat(framework): Make _property-change publicly available #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
previously approved these changes
Sep 14, 2020
ilhan007
previously approved these changes
Sep 16, 2020
ilhan007
approved these changes
Sep 16, 2020
Todor-ads
pushed a commit
to Todor-ads/ui5-webcomponents
that referenced
this pull request
Sep 17, 2020
vladitasev
added a commit
that referenced
this pull request
Oct 2, 2020
ilhan007
pushed a commit
that referenced
this pull request
Oct 17, 2020
ilhan007
pushed a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenUI5 integration requires that OpenUI5 controls know of every property change. Currently there is a
_property-changeevent, but it has very special use cases. It is fired only if a component is listеning to its children's property changes. And the check whether to fire the event or not is related to the children being listened to or not.This change changes the condition whether
_property-changeis fired or not. Now it is based on whether there are any listeners for the event, which makes it possible to subscribe from the outside too.Additionally, a long-lasting bug with
listenForwas fixed: if the first child to go to that slot has no properties (such as tab separator), then no properties are listened for for the other children (such as tab).Additionally, the
_property-changeevent is now non-bubbling, because the condition to fire the event or not is based on the presence of direct listeners.