Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-multi-combobox): make focus outline visible #2286

Closed
wants to merge 1 commit into from
Closed

fix(ui5-multi-combobox): make focus outline visible #2286

wants to merge 1 commit into from

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Oct 1, 2020

Fixes #2263

ilhan007
ilhan007 requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, when a token is focused,you have double focus - on the token and on the input.

@fifoosid
Copy link
Contributor Author

This issue is in the roadmap of team Rila

@fifoosid fifoosid closed this Oct 13, 2020
@fifoosid fifoosid deleted the mcb-focus branch October 13, 2020 11:53
@ivoplashkov ivoplashkov mentioned this pull request Nov 2, 2020
Merged
MapTo0 pushed a commit that referenced this pull request Nov 5, 2020
@ivoplashkov
fix(ui5-multi-combobox): make focus outline visible (#2431)
cd5fad2 
FIXES: #2286
ilhan007 pushed a commit that referenced this pull request Nov 19, 2020
@ivoplashkov @ilhan007
fix(ui5-multi-combobox): make focus outline visible (#2431)
d516b95 
FIXES: #2286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-multi-combobox] missing focus outline
2 participants
@fifoosid @ilhan007