Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-side-navigation-item, ui5-side-navigation-sub-item): introduce click event #2298

Merged
merged 5 commits into from
Nov 24, 2020
Merged

feat(ui5-side-navigation-item, ui5-side-navigation-sub-item): introduce click event #2298

merged 5 commits into from
Nov 24, 2020

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Oct 5, 2020 •
edited by ilhan007
Loading

This PR introduces the following features:

  1. For ui5-side-navigation-item:
  • click event
  • whole-item-toggleable property
  1. For ui5-side-navigation-sub-item:
  • click event

Fixes #2293

@rkl1994 rkl1994 mentioned this pull request Oct 22, 2020
Closed
@ilhan007 ilhan007 changed the title feat(ui5-side-navigation-item, ui5-side-navigation-side-item): introd… feat(ui5-side-navigation-item, ui5-side-navigation-sub-item): introduce click event Nov 23, 2020
@ilhan007 ilhan007 self-requested a review November 23, 2020 12:00
ilhan007
ilhan007 previously approved these changes Nov 23, 2020
View reviewed changes
@fifoosid fifoosid merged commit d73ce38 into master Nov 24, 2020
@fifoosid fifoosid deleted the side-nav-toggle branch November 24, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
Autopilot for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose click & toggle events for Side Navigation
2 participants
@fifoosid @ilhan007