Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-select): select opens with space #245

Merged
merged 2 commits into from
Mar 25, 2019
Merged

feat(ui5-select): select opens with space #245

merged 2 commits into from
Mar 25, 2019

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Mar 25, 2019 •
edited
Loading

No description provided.

ilhan007
ilhan007 reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test please

@fifoosid fifoosid merged commit a6c4d29 into master Mar 25, 2019
@fifoosid fifoosid deleted the select-keyboard-opening branch March 25, 2019 21:25
vladitasev pushed a commit that referenced this pull request Mar 26, 2019
@fifoosid @vladitasev
feat(ui5-select): select opens with space (#245)
4f0a623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fifoosid @ilhan007