fix(ui5-select): remove aria-roledescription #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested changes
Nov 12, 2020
The reledescription prevents its role of button to be read by JAWS. Fixes SAP#2358
|
Thanks for the hint! I updated the change... |
fifoosid
reviewed
Nov 17, 2020
There was a problem hiding this comment.
I think it would be a good idea if @dobrinyonkov takes a look at the PR and say if it covers the whole issue.
Technically, the change looks good to me and I can approve.
ilhan007
approved these changes
Nov 18, 2020
ndeshev
pushed a commit
to ndeshev/ui5-webcomponents
that referenced
this pull request
Nov 18, 2020
The reledescription prevents its role of button to be read by JAWS. Fixes SAP#2358
ilhan007
pushed a commit
that referenced
this pull request
Nov 19, 2020
The reledescription prevents its role of button to be read by JAWS. Fixes #2358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reledescription prevents its role button to be read by JAWS
so it is now removed following consultation with ACC expert.
Fixes #2358