fix(ui5-upload-collection): fire drop only when files are dropped within dnd overlay #2527
Conversation
…hin dnd overlay Fixes: #2001
|
|
packages/base/src/UI5Element.js
Outdated
| @@ -712,7 +712,7 @@ class UI5Element extends HTMLElement { | |||
| // This will be false if the normal event is prevented | |||
| const normalEventResult = this.dispatchEvent(customEvent); | |||
|
|
|||
| // Return false if any of the two events was prevented (its result was false). | |||
| // Return false if any of the two events were prevented (its result was false). | |||
There was a problem hiding this comment.
Are you sure it must be "were" since "any" is the subject in the sentence (and not "events") and it is singular. One would say "return false if any event was prevented", hence "return false if any of the events was prevented" (and "any" is still the subject). Anyway, not important, just curious :)
There was a problem hiding this comment.
I read a bit more about this. "Any of" here is plural. Turns out, both forms of the verb are accepted. Use of the singular form is more "formal", plural is more "informal". I'll revert it back since this isn't a grammar error as I thought. See 2. 'any of' here.
| @@ -125,6 +125,16 @@ const metadata = { | |||
| }, | |||
| }, | |||
| events: /** @lends sap.ui.webcomponents.fiori.UploadCollection.prototype */ { | |||
| /** | |||
| * Fired when an element is dropped inside the drag and drop overlay. | |||
There was a problem hiding this comment.
Normally we don't document browser events, because they are fired and work anyway. However, we do this for browser events that we modify (such as this one) in order to explain what is different than the expected normal behavior. What you described here is correct, but it would have been correct before the change too. So I'd suggest adding:
<b>Note:</b> The <code>drop</code> event is fired only for the drag and drop overlay and ignored for the other parts of the <code>ui5-upload-collection</code>
or something to this effect.
Fixes: #2001