Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checks navigator language for rtl enabling #253

Merged
merged 2 commits into from
Mar 27, 2019
Merged

fix: checks navigator language for rtl enabling #253

merged 2 commits into from
Mar 27, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Mar 26, 2019

  • RTL is now set from the configuration by priority. If no configuration
    is defined for the rtl or language - navigator lanaguage is checked

fix: checks navigator language for rtl enabling
bcbccb1 
- RTL is now set from the configuration by priority. If no configuration
is defined for the rtl or language - navigator lanaguage is checked.
@MapTo0 MapTo0 requested a review from pskelin March 26, 2019 12:25
pskelin
pskelin requested changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@pskelin pskelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than the empty default export

packages/base/src/RTL.js Outdated Show resolved Hide resolved
@MapTo0 MapTo0 merged commit c29d970 into master Mar 27, 2019
@MapTo0 MapTo0 deleted the locale-based-rtl branch March 27, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskelin pskelin pskelin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MapTo0 @pskelin