Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-icon): remove vertical icon flip in RTL #2645

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

pskelin
Copy link
Contributor

@pskelin pskelin commented Jan 8, 2021

Icons used to have a wrong double vertical flip. This was removed, but
the RTL selectors were missed.

Fixes #2644

Icons used to have a wrong doulbe vertical flip. This was removed, but
the RTL selectors were missed.
@pskelin pskelin requested a review from ilhan007 January 8, 2021 09:24
@ilhan007
Copy link
Member

ilhan007 commented Jan 8, 2021

Thanks for the quick fix

@ilhan007 ilhan007 merged commit 0120960 into master Jan 8, 2021
@ilhan007 ilhan007 deleted the fix-icon-vertical-flip-rtl branch January 8, 2021 09:56
ilhan007 pushed a commit that referenced this pull request Mar 18, 2021
Icons used to have a wrong double vertical flip. This was removed, but
the RTL selectors were missed.

Fixes #2644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-icon: rtl direction causes icons to be flipped in both directions
2 participants