fix(ui5-input): focus is handled properly #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapTo0
requested changes
Jan 19, 2021
| @@ -237,6 +237,18 @@ class MultiInput extends Input { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @override | |||
ilhan007
reviewed
Jan 20, 2021
| @@ -371,4 +371,19 @@ describe("Input general interaction", () => { | |||
| assert.notOk(inputPopover.isDisplayedInViewport(), "The inpuit popover is closed as it lost the focus."); | |||
| assert.ok(helpPopover.isDisplayedInViewport(), "The help popover remains open as the focus is within."); | |||
| }); | |||
|
|
|||
| it("Should open suggestions popover when ui5-input is the fisrt focusable element within a dialog", () => { | |||
ilhan007
approved these changes
Jan 20, 2021
MapTo0
approved these changes
Jan 22, 2021
ilhan007
pushed a commit
that referenced
this pull request
Jan 22, 2021
kineticjs
pushed a commit
to kineticjs/ui5-webcomponents
that referenced
this pull request
Jan 25, 2021
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on focus the ui5-input component, when the event target was ui5-input, the focused attribute was not added. As a result, the focus outline was not presented, as well as the suggestions were not visualised initially when used.
Fixes #2652