feat: create @ui5/webcomponents-ie11 package #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
changed the title
ilhan007
changed the title
pskelin
reviewed
Jan 20, 2021
packages/base/src/EventProvider.js
Outdated
| @@ -55,6 +54,17 @@ class EventProvider { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * Fires an event, awaits for all listeners' results to have resolved, and returns the results as an array. | |||
There was a problem hiding this comment.
technically it doesn't await but returns the promises, could you change the description simply that it returns a promise and is always async?
packages/base/src/EventProvider.js
Outdated
| * | ||
| * @param eventName the event to fire | ||
| * @param data optional data to pass to each event listener | ||
| * @returns {Array} an array with the results of all event listeners |
There was a problem hiding this comment.
a single promise is returned, when resolved it will have the values
packages/base/src/UI5Element.js
Outdated
|
|
||
| // FF, Safari | ||
| if (!document.adoptedStyleSheets && !window.ShadyDOM) { | ||
| } else if (hasNativeSupport()) { // FF, Safari |
There was a problem hiding this comment.
hasNativeSupport for what? I had to check the implementation, this name is too generic.
pskelin
approved these changes
Jan 20, 2021
kineticjs
pushed a commit
to kineticjs/ui5-webcomponents
that referenced
this pull request
Jan 25, 2021
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move IE11-specific code from
baseto a new packageThis change reduces the ES6 bundle size by 4KB (by 2KB gzipped) by moving away IE11-specific code. The size of the ES5 bundle remains unchanged.
Changes:
@ui5/webcomponents-ie11: new package that maintains all IE-related code. It uses framework hooks to plug seamlessly into the framework.basepackage is completely free of IE11 code. It exposes a few new lifecycle hooks.mainandfioripackages depend on@ui5/webcomponents-ie11and import its features (IE11.js).Edge.jsfile, aimed at legacy Edge, has been removed. Legacy Edge should be treated as IE in terms of ES6 support, therefore it will work with the ES5 code, but not with the ES6 code, due to Legacy Edge not supporting object spread operator and rest parameters syntax, which are used throughout the framework and components.Refactoring:
baseproject no longer understands the business logic of IE11 support (such as ShadyDOM, loading the polyfill, the CSS ponyfill, creating the IE style tags) but exposes lifecycle hooks instead.UI5Element.jsandStaticAreaItem.js: now they both use the same internal functions and follow the same flow.getEffectiveStylefunction now works for the static area too (has an extra parameter). In addition, this function is now reused by the IE11 code.IE11 code lifecycle
IE11 CSS processing
BREAKING CHANGES:
basepackage to the newie11package. If you used them before:@ui5/webcomponents-ie11as a dependency to your projectnpm i @ui5/webcomponents-ie11 --saveor
yarn add @ui5/webcomponents-ie11import "@ui5/webcomponents-base/dist/features/browsersupport/IE11.js";to
import "@ui5/webcomponents-ie11/dist/features/IE11.js";and
import "@ui5/webcomponents-base/dist/features/browsersupport/IE11WithWebComponentsPolyfill.js";to
import "@ui5/webcomponents-ie11/dist/features/IE11WithWebComponentsPolyfill.js";import "@ui5/webcomponents-base/dist/features/browsersupport/Edge.js";Legacy Edge is still supported with the ES5 bundle. If your app needs to support Legacy Edge, treat it as IE11 and transpile the code to ES5 as you would for IE11.