Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-slider, ui5-range-slider): Implement accessibility specifications #2714

Merged
merged 10 commits into from
Jan 26, 2021
Merged

feat(ui5-slider, ui5-range-slider): Implement accessibility specifications #2714

merged 10 commits into from
Jan 26, 2021

Conversation

ivoplashkov
Copy link
Member

FIXES: #2513

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

elenastoyanovaa
elenastoyanovaa requested changes Jan 22, 2021
View reviewed changes
packages/main/src/i18n/messagebundle.properties Outdated Show resolved Hide resolved
packages/main/src/i18n/messagebundle.properties Outdated Show resolved Hide resolved
packages/main/src/i18n/messagebundle.properties Outdated Show resolved Hide resolved
packages/main/src/i18n/messagebundle.properties Outdated Show resolved Hide resolved
packages/main/src/RangeSlider.js Outdated Show resolved Hide resolved
@ilhan007 ilhan007 added the ACC label Jan 22, 2021
elenastoyanovaa
elenastoyanovaa requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it is a good idea to add some tests regarding the swap of the aria-labelledby in the range slider handles.

ndeshev
ndeshev reviewed Jan 25, 2021
View reviewed changes
packages/main/src/Slider.js Outdated Show resolved Hide resolved
packages/main/src/RangeSlider.hbs Outdated Show resolved Hide resolved
packages/main/src/RangeSlider.js Show resolved Hide resolved
@ivoplashkov
Copy link
Member Author

Thanks for the reviews, comments are applied.

elenastoyanovaa
elenastoyanovaa requested changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both slider and range slider are focusable when disabled, could you remove the focus, when the components are disabled?

@ivoplashkov
Copy link
Member Author

Both slider and range slider are focusable when disabled, could you remove the focus, when the components are disabled?

Done.

@ilhan007 ilhan007 merged commit cb76cf4 into SAP:master Jan 26, 2021
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this pull request Feb 1, 2021
@ivoplashkov @alexandar-mitsev
feat(ui5-slider, ui5-range-slider): implement a11y spec (SAP#2714)
9f5691e 
FIXES: SAP#2513
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this pull request Feb 9, 2021
@ivoplashkov @NHristov-sap
feat(ui5-slider, ui5-range-slider): implement a11y spec (SAP#2714)
8d3b737 
FIXES: SAP#2513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeshev ndeshev ndeshev left review comments

@elenastoyanovaa elenastoyanovaa elenastoyanovaa approved these changes

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
ACC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Range)Slider: implement accessibility specs
5 participants
@ivoplashkov @CLAassistant @ndeshev @elenastoyanovaa @ilhan007