fix(ui5-icon): alignment issue in Safari #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ui5-icon-root SVG is now forced with style "vertical-align: top" which fixes the misalignment. - no regressions introduced in the rest of the browsers.
|
|
ilhan007
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
It is interesting, because vertical-align: top; should not take effect based on the docs:
Note that vertical-align only applies to inline, inline-block and table-cell elements: you can't use it to vertically align block-level elements.
And the element that it is applied is display:flex, but I tested and it fixes the issue, so I will approve it.
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
- ui5-icon-root SVG is now forced with style "vertical-align: top" which fixes the misalignment. - no regressions introduced in the rest of the browsers.
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
- ui5-icon-root SVG is now forced with style "vertical-align: top" which fixes the misalignment. - no regressions introduced in the rest of the browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which fixes the misalignment.
FIXES: #913