feat(ui5-multi-input): Implement accessibility specifications #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenastoyanovaa
approved these changes
Feb 1, 2021
|
Approved from ACC side. @niyap Could you update the wiki page of the ui5-multiinput, including the speech output? |
MapTo0
approved these changes
Feb 1, 2021
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
ilhan007
pushed a commit
that referenced
this pull request
Feb 8, 2021
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui5-multi-input is implemented according to the specification.
As part of the change, an existing accessibility issue in ui5-multi-combobox component is fixed as well. Now, the information about the contained tokens is added to aria-describedby attribute instead of aria-labelledby, because it is more appropriate, since the information is a descriptive text.
FIXES: #2705
FIXES: #2459